vergissberlin /
mqtt-resource
| Conditions | 19 |
| Paths | 6480 |
| Total Lines | 64 |
| Code Lines | 36 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like validate.js ➔ configuration often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | 'use strict' |
||
| 12 | configuration(input, callback) { |
||
| 13 | |||
| 14 | let error = null |
||
| 15 | |||
| 16 | if ( !input.source.url ) { |
||
| 17 | if ( !error ) { |
||
| 18 | error = new Error('URL for MQTT broker has not been set.') |
||
| 19 | } |
||
| 20 | } |
||
| 21 | |||
| 22 | if ( !this.url(input.source.url) ) { |
||
| 23 | if ( !error ) { |
||
| 24 | error = new Error('Your defined URL is invalid. It should start with mqtt://') |
||
| 25 | } |
||
| 26 | } |
||
| 27 | |||
| 28 | let port = Number.parseInt(input.source.port) |
||
| 29 | if ( Number.isNaN(port) ) { |
||
| 30 | input.source.port = 1883 |
||
| 31 | } else { |
||
| 32 | input.source.port = port |
||
| 33 | } |
||
| 34 | |||
| 35 | if ( !input.source.username ) { |
||
| 36 | if ( !error ) { |
||
| 37 | error = new Error('The user name for MQTT broker has not been set.') |
||
| 38 | } |
||
| 39 | } |
||
| 40 | |||
| 41 | if ( !input.source.password ) { |
||
| 42 | if ( !error ) { |
||
| 43 | error = new Error('The password for MQTT broker has not been set.') |
||
| 44 | } |
||
| 45 | } |
||
| 46 | |||
| 47 | if ( !input.source.topic && !input.params.topic ) { |
||
| 48 | if ( !error ) { |
||
| 49 | error = new Error('The parameter topic has not been set.') |
||
| 50 | } |
||
| 51 | } else if(input.params) { |
||
| 52 | input.source.topic = input.params.topic || input.source.topic |
||
| 53 | } |
||
| 54 | |||
| 55 | |||
| 56 | if ( !input.params ) { |
||
| 57 | if ( !error ) { |
||
| 58 | error = new Error('The parameters are not been set.') |
||
| 59 | } |
||
| 60 | } else { |
||
| 61 | if ( !input.params.payload ) { |
||
| 62 | if ( !error ) { |
||
| 63 | error = new Error('The parameter payload has not been set.') |
||
| 64 | } |
||
| 65 | } else { |
||
| 66 | input.params.payload.toString() |
||
| 67 | } |
||
| 68 | |||
| 69 | if ( ![0, 1, 2].includes(input.params.qos) ) { |
||
| 70 | input.params.qos = 0 |
||
| 71 | } |
||
| 72 | } |
||
| 73 | |||
| 74 | callback(input, error) |
||
| 75 | } |
||
| 76 | |||
| 80 |
